Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command JSON.OBJLEN #499

Closed
arpitbbhayani opened this issue Sep 8, 2024 · 6 comments · Fixed by #593
Closed

Add support for command JSON.OBJLEN #499

arpitbbhayani opened this issue Sep 8, 2024 · 6 comments · Fixed by #593
Assignees
Labels

Comments

@arpitbbhayani
Copy link
Contributor

arpitbbhayani commented Sep 8, 2024

Add support for the JSON.OBJLEN command in DiceDB similar to the JSON.OBJLEN command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@rushabhk04
Copy link
Contributor

Assign this issue to me. Thanks

@lucifercr07
Copy link
Contributor

@rushabhk04 assigned, thanks for picking this up.

@iamskp11
Copy link
Contributor

Hey @lucifercr07 @rushabhk04 ,
Since there are no updates here since 5 days, is this still being worked on? Will be happy to work on this

@rushabhk04
Copy link
Contributor

Yes, please go ahead with it. Thanks

@iamskp11
Copy link
Contributor

Hey @lucifercr07 , have picked this one, and have done basic method implementation. Will be sharing PR post tests and benchmarking memory + time. Thanks!

@phaneesh707
Copy link
Contributor

Hey @iamskp11 , i'm really sorry didn't notice that you are also working on it , since this issue was inactive i just started working on and created a PR for it.Sorry!
@lucifercr07 could you please review the PR,thanks.

JyotinderSingh added a commit that referenced this issue Sep 17, 2024
Co-authored-by: Jyotinder Singh <jyotindrsingh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants