Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for command JSON.DEBUG HELP #492

Closed
arpitbbhayani opened this issue Sep 8, 2024 · 3 comments
Closed

Add support for command JSON.DEBUG HELP #492

arpitbbhayani opened this issue Sep 8, 2024 · 3 comments
Assignees

Comments

@arpitbbhayani
Copy link
Contributor

arpitbbhayani commented Sep 8, 2024

Add support for the JSON.DEBUG HELP command in DiceDB similar to the JSON.DEBUG HELP command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@kaifkh20
Copy link

kaifkh20 commented Sep 9, 2024

I think issue #493 will be sufficient for this.

@psrvere
Copy link
Contributor

psrvere commented Sep 9, 2024

I agree.

@lucifercr07 - #491 #492 and #493 are referring to just one command with two subcommands: json.debug help and json.debug memory. The former subcommand is just help text. Should we combine these 3 as one issue?

@lucifercr07
Copy link
Contributor

We can keep the issues open as it is for reference purpose. You can work on both i.e. #492 and #493 together, will assign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants