-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating and respecting dice.conf
file
#421
Comments
@arpitbbhayani would like to work on this. |
@lucifercr07 thanks for taking this up. go for it! |
@arpitbbhayani could you assign it to me? |
@arpitbbhayani Can you assign me this issue. I want to work on this |
Hello @vinitparekh17, There has been no activity on this issue for the past 5 days. We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work. Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out. Thanks again. |
@arpitbbhayani Can I pick this up? |
@arpitbbhayani To add to this, presence of flags to cmd line params will always have highest priority than config file. I really liked how convoy uses configs, combining with presence of flags |
Hello @arpitbbhayani, Thank you for the reminder. I’ve been actively incorporating feedback from the community and am working to complete the task soon. You can check the progress in the PR here. I appreciate your patience and will provide updates as I move forward. If you have any questions or additional feedback, please let me know! Thanks again. |
Hello @vinitparekh17, I see your PR got merged. #450 Thank you so much for taking this up. this was one of the most critical things that we wanted for a great UX and so happy to see this getting merged :) super thanks for doing this. should I close this issue now? |
@arpitbbhayani, It's an honor to be part of this community, and I look forward to working on more issues like this in the future. If our desired outcome has been fulfilled, we can go ahead and close this issue. Once again, thank you for your patience and for giving me the opportunity to contribute. |
Closing the issue, merged as part of #450. Thanks @vinitparekh17 for contributing. |
Add one sub-command in
dice
calledinit-config
that would create the.conf
file for DiceDB. This file should be exactly whatredis.conf
is. It is okay if we are not supporting all options and configurations mentioned. Let's respect the following to start withport
requirepass
The default path of the dice.conf file should be
/etc/dicedb/dice.conf
. But by passing-o
ininit-config
we should be able to change the location.Also, add support for flag
-c <path to config file>
that user can pass while starting the server. and we should read the config and respect the configurations.When the server starts, if
-c
flag is passed, read and use that config file. if notdice.conf
in current directory/etc/dicedb/dice.conf
filemaintain this as a list in the code so that we can define the order in which we will check the presence of the conf file.
Also, when the server starts, output the
dice.conf
file it is using.Note, For every configuration in
dice.conf
there will be a sane default and if no conf exists, we use that sane default.The text was updated successfully, but these errors were encountered: