-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for command COPY
#277
Comments
@arpitbbhayani can you assign this to me? |
@srivastava-yash Assigned the issue to you. Go for it. It would be awesome if you keep posting updates to this issue so that we know you are working on it. If we see an inactivity of 7 days, we will remove your assignment. This is just to ensure that the project maintains its momentum and others are not blocked on this work. But it really means a ton to us that you are contributing to this project. Thanks again. |
Had a question about a command option. |
We currently only have one logical database in our system. We don't need to support destination-db option yet, you can skip it. |
I have completed the copy functions for some data structures. Will post a draft PR today for feedback. Will complete the tests and update when its ready for review |
PR is up for review. #305 |
Add support for the
COPY
command in DiceDB similar to theCOPY
command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the
tests
folder. Note: they have usedTCL
for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.For the command, benchmark the code and measure the time taken and memory allocs using
benchmem
and try to keep them to the bare minimum.The text was updated successfully, but these errors were encountered: