-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PFMERGE
command
#241
Comments
PFMERGE
for HyperLogLog
PFMERGE
for HyperLogLogPFMERGE
command
Hey @Vsareen0 Do you have any updates on this? If you have any blockers lets discuss this over the discord. Or if you have multiple items on the plate, lets open this issue for everyone, and others can pick this up. cc - @JyotinderSingh |
Have started working on this as part of follow up PR to #422 (Adding |
lucifercr07
added a commit
to lucifercr07/dice
that referenced
this issue
Sep 9, 2024
JyotinderSingh
pushed a commit
that referenced
this issue
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add support for the
PFMERGE
command in DiceDB similar to thePFMERGE
command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the
tests
folder. Note: they have usedTCL
for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.For the command, benchmark the code and measure the time taken and memory allocs using
benchmem
and try to keep them to the bare minimum.The text was updated successfully, but these errors were encountered: