Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PFMERGE command #241

Closed
Vsareen0 opened this issue Aug 4, 2024 · 2 comments
Closed

Add support for PFMERGE command #241

Vsareen0 opened this issue Aug 4, 2024 · 2 comments
Assignees

Comments

@Vsareen0
Copy link
Contributor

Vsareen0 commented Aug 4, 2024

Add support for the PFMERGE command in DiceDB similar to the PFMERGE command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@Vsareen0 Vsareen0 changed the title Add command for PFMERGE Add command for PFMERGE for HyperLogLog Aug 4, 2024
@arpitbbhayani arpitbbhayani changed the title Add command for PFMERGE for HyperLogLog Add support for PFMERGE command Aug 4, 2024
@AshwinKul28
Copy link
Contributor

Hey @Vsareen0 Do you have any updates on this? If you have any blockers lets discuss this over the discord. Or if you have multiple items on the plate, lets open this issue for everyone, and others can pick this up.
Thanks

cc - @JyotinderSingh

@lucifercr07
Copy link
Contributor

Have started working on this as part of follow up PR to #422 (Adding PFCOUNT, PFADD)

@AshwinKul28 AshwinKul28 assigned lucifercr07 and unassigned Vsareen0 Sep 8, 2024
lucifercr07 added a commit to lucifercr07/dice that referenced this issue Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants