Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle INT64_MIN edge case in EncodeInt/DecodeInt #221

Closed
JyotinderSingh opened this issue Aug 3, 2024 · 2 comments
Closed

Handle INT64_MIN edge case in EncodeInt/DecodeInt #221

JyotinderSingh opened this issue Aug 3, 2024 · 2 comments

Comments

@JyotinderSingh
Copy link
Collaborator

The current implementation of EncodeInt and DecodeInt may not correctly handle the minimum 64-bit integer value due to potential overflow in two's complement arithmetic. We need to add a specific test case for this value and ensure correct behavior.
Tasks:

Requirements

  • Add a test case for INT64_MIN in int_test.go
  • Verify correct encoding and decoding of INT64_MIN
  • If issues are found, implement a fix in EncodeInt and/or DecodeInt functions
@Vsareen0
Copy link
Contributor

Vsareen0 commented Aug 3, 2024

Hey @JyotinderSingh I would like to pick this.

@JyotinderSingh
Copy link
Collaborator Author

Hey @JyotinderSingh I would like to pick this.

Assigned.

SyedMa3 pushed a commit to SyedMa3/dice that referenced this issue Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants