Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMMAND LIST command #149

Closed
arpitbbhayani opened this issue Jul 12, 2024 · 8 comments · Fixed by #418
Closed

Add support for COMMAND LIST command #149

arpitbbhayani opened this issue Jul 12, 2024 · 8 comments · Fixed by #418

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the COMMAND LIST command in DiceDB similar to the COMMAND LIST command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

yashs360 added a commit to yashs360/dice that referenced this issue Jul 12, 2024
yashs360 added a commit to yashs360/dice that referenced this issue Jul 12, 2024
JyotinderSingh added a commit that referenced this issue Jul 14, 2024
@patelajay745
Copy link

I want to work on this .

@yashs360
Copy link
Contributor

Hey @patelajay745 I am working on it currently with the PR's linked up. Please pick other issues from the list.

yashs360 added a commit to yashs360/dice that referenced this issue Jul 15, 2024
@KaviiSuri
Copy link
Contributor

@arpitbbhayani i want to work on this, is it free to pick up? can it be assigned?

@Harsh-2909
Copy link

@arpitbbhayani @JyotinderSingh Can I work on this issue if nobody is working on it?

@JyotinderSingh
Copy link
Collaborator

@arpitbbhayani i want to work on this, is it free to pick up? can it be assigned?

Assigned

@JyotinderSingh
Copy link
Collaborator

@arpitbbhayani @JyotinderSingh Can I work on this issue if nobody is working on it?

Have assigned to @KaviiSuri since he messaged first. Please have a look at any other open issues or inactive issues which are assigned but not being worked on. Thanks @Harsh-2909!

@AshwinKul28
Copy link
Contributor

@KaviiSuri Thanks a lot for picking this up. Do you have any latest updates on this? If you have any blockers lets discuss this over the Discord.

@KaviiSuri
Copy link
Contributor

Hey @AshwinKul28 , i had issues with my system for the past week and only got it back this sunday.

It seems like someone else completed the issue in the meanwhile. Is there anything else i can pickup or contribute too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants