Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for COMMAND GETKEYS command #147

Closed
arpitbbhayani opened this issue Jul 12, 2024 · 3 comments · Fixed by #224
Closed

Add support for COMMAND GETKEYS command #147

arpitbbhayani opened this issue Jul 12, 2024 · 3 comments · Fixed by #224

Comments

@arpitbbhayani
Copy link
Contributor

Add support for the COMMAND GETKEYS command in DiceDB similar to the COMMAND GETKEYS command in Redis. Please refer to the following commit in Redis to understand the implementation specifics - source.

Write unit and integration tests for the command referring to the tests written in the Redis codebase 7.2.5. For integration tests, you can refer to the tests folder. Note: they have used TCL for the test suite, and we need to port that to our way of writing integration tests using the relevant helper methods. Please refer to our tests directory.

For the command, benchmark the code and measure the time taken and memory allocs using benchmem and try to keep them to the bare minimum.

@Yonggiee
Copy link
Contributor

Hey @kakdeykaushik, can I confirm if you are currently working on this issue? If not, I would like to work on this.

@kakdeykaushik
Copy link
Contributor

I'm not working on this GETKEYS please go ahead to pick it up.

@arpitbbhayani
Copy link
Contributor Author

@Yonggiee I have assigned the issue to you. Thanks.

arpitbbhayani added a commit that referenced this issue Aug 3, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
#147: Add support for COMMAND GETKEYS command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants