Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fixes in the CI #1260

Closed
kitarp29 opened this issue Nov 9, 2024 · 5 comments · Fixed by #1265
Closed

New fixes in the CI #1260

kitarp29 opened this issue Nov 9, 2024 · 5 comments · Fixed by #1265
Assignees

Comments

@kitarp29
Copy link
Contributor

kitarp29 commented Nov 9, 2024

As discussed here: #1116 (comment)
I am opening a new issue for these two changes in the CI

  • Conditional triggering of linting and Testing pipeline when changes are done to only .go file (This can change if the project ever changes/includes anything other than go)
  • Caching setup for the linting job as well

Please make it open for all, since it's a simple change for beginners. If no one does it in a week or so.
I will make a PR against it

cc: @JyotinderSingh

@bhima2001
Copy link
Contributor

Hey I can take this up.

@kitarp29
Copy link
Contributor Author

kitarp29 commented Nov 9, 2024

I am not the maintainer or the repo, but I suggest you work on the changes. They should not take more than an hour (see the changes I made earlier).

@apoorvyadav1111
Copy link
Contributor

Hi @bhima2001 , Assigned. Thanks for contributing to DiceDB.

@bhima2001
Copy link
Contributor

@kitarp29 Hey, Is there any way I can test the workflow locally? Thanks

@kitarp29
Copy link
Contributor Author

Make a fork of this project on your account.
On your clone:

  1. Have the CI changes in main branch
  2. Make a branch out of this branch. Make commits on that branch it would help you to test the changes in the fashion you wish to.

If satisfied make a PR with the main branch of your fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants