Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent LPOP: Command doesn't support multiple args #1100

Closed
lucifercr07 opened this issue Oct 15, 2024 · 5 comments
Closed

Inconsistent LPOP: Command doesn't support multiple args #1100

lucifercr07 opened this issue Oct 15, 2024 · 5 comments
Assignees
Labels
bug Something isn't working stack -- go

Comments

@lucifercr07
Copy link
Contributor

Steps to reproduce

> RPUSH mylist "one" "two" "three" "four" "five"
(integer) 5
> LPOP mylist 2
(error) ERR wrong number of arguments for 'lpop' command

Expected output

The expected output when the above set of commands (maybe when run on Redis)

redis> LPOP mylist 2
1) "two"
2) "three"

Observed output

The observed output when the above set of commands when run on DiceDB

0.0.0.0:7379> LPOP mylist 2
(error) ERR wrong number of arguments for 'lpop' command

Expectations for resolution

This issue will be considered resolved when the following things are done

  1. changes in the dice code to meet the expected behaviour
  2. addition of relevant test case to ensure we catch the regression

You can find the tests under the integration_tests directory of the dice repository and the steps to run are in the README file. Refer to the following links to set up DiceDB and Redis 7.2.5 locally

@lucifercr07 lucifercr07 added bug Something isn't working stack -- go labels Oct 15, 2024
@bhima2001
Copy link
Contributor

@lucifercr07 I would like to work on this.

@tren03
Copy link
Contributor

tren03 commented Oct 15, 2024

Hey!
I am new in the community and didn't know if I could solve this issue but I gave it a go
Here are the results

dice-output

I tried including all the testcases I could think of, and tried to get the output as similar as i could to redis output
this is the redis output

redis-output

@Dhroov7
Copy link
Contributor

Dhroov7 commented Oct 16, 2024

@lucifercr07 If this issue is still open, Can i pick this up?

@arpitbbhayani
Copy link
Contributor

Hello @tren03,

There has been no activity on this issue for the past 5 days.
It would be awesome if you keep posting updates to this issue so that we know you are actively working on it.

We are really eager to close this issue at the earliest, hence if we continue to see the inactivity, we will have to reassign the issue to someone else. We are doing this to ensure that the project maintains its momentum and others are not blocked on this work.

Just drop a comment with the current status of the work or share any issues you are facing. We can always chip in to help you out.

Thanks again.

@Kripu77
Copy link
Contributor

Kripu77 commented Nov 1, 2024

Hey Guys,

This issue is exactly what issue number #1057 resolves which I've been working on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stack -- go
Projects
None yet
Development

No branches or pull requests

7 participants