Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make get beamline name return unchanged beamline #66

Merged
merged 2 commits into from
May 22, 2023

Conversation

dperl-dls
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #66 (756cd3d) into main (491bb53) will increase coverage by 21.27%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #66       +/-   ##
===========================================
+ Coverage   64.54%   85.81%   +21.27%     
===========================================
  Files          52       52               
  Lines        1681     1678        -3     
===========================================
+ Hits         1085     1440      +355     
+ Misses        596      238      -358     
Impacted Files Coverage Δ
src/dodal/i03.py 91.13% <100.00%> (+91.13%) ⬆️
src/dodal/utils.py 100.00% <100.00%> (+100.00%) ⬆️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think i03 should still give you s03 if you have no BEAMLINE, I have put this in

@DominicOram DominicOram merged commit dcac18a into main May 22, 2023
@DominicOram DominicOram deleted the artemis_661_fix_get_beamline_name branch May 22, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants