Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make device factory decorator #597

Open
wants to merge 59 commits into
base: main
Choose a base branch
from
Open

make device factory decorator #597

wants to merge 59 commits into from

Commits on Sep 20, 2024

  1. example beamline with implementation

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    87db849 View commit details
    Browse the repository at this point in the history

  2. small cleanup

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    40ed12d View commit details
    Browse the repository at this point in the history

  3. added controller demonstration

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fae6b03 View commit details
    Browse the repository at this point in the history

  4. fix wrong extension

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dc24a72 View commit details
    Browse the repository at this point in the history

  5. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1aba14d View commit details
    Browse the repository at this point in the history

  6. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f37e47a View commit details
    Browse the repository at this point in the history

  7. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5b76ee9 View commit details
    Browse the repository at this point in the history

  8. Update src/dodal/beamlines/example_beamline.py 

    Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
    @stan-dot @coretl
    stan-dot and coretl committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b1cb6c6 View commit details
    Browse the repository at this point in the history

  9. fix example beamline into a dataclass

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9b8dd56 View commit details
    Browse the repository at this point in the history

  10. new-i22 as an example

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    53284f5 View commit details
    Browse the repository at this point in the history

  11. respond to feedback

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    651dba5 View commit details
    Browse the repository at this point in the history

  12. respond to comments

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    66d4435 View commit details
    Browse the repository at this point in the history

  13. initial test

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    38b5405 View commit details
    Browse the repository at this point in the history

  14. comment out some tests to check coverage

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f898a20 View commit details
    Browse the repository at this point in the history

  15. lint

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fba891a View commit details
    Browse the repository at this point in the history

  16. use factory name for active devices dict key

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c2db1be View commit details
    Browse the repository at this point in the history

  17. this cannot be active devices, globals harder to mock

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a063063 View commit details
    Browse the repository at this point in the history

  18. amend the test

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cc294bc View commit details
    Browse the repository at this point in the history

  19. added a red test for caching by name

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dbcd197 View commit details
    Browse the repository at this point in the history

  20. fix the tests and add the support for a name flag

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    931ada0 View commit details
    Browse the repository at this point in the history

  21. add the API for blueapi

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6345907 View commit details
    Browse the repository at this point in the history

  22. remove todos

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a4b0974 View commit details
    Browse the repository at this point in the history

  23. unused utils deleted for coverage

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0ce1de4 View commit details
    Browse the repository at this point in the history

  24. Just one i22 now

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b8137e0 View commit details
    Browse the repository at this point in the history

  25. respond to comments

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9090bb8 View commit details
    Browse the repository at this point in the history

  26. rename to device factory

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7b9b123 View commit details
    Browse the repository at this point in the history

  27. is this enough to replace skip_device()

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    beb4d98 View commit details
    Browse the repository at this point in the history

  28. ruff

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7b546e7 View commit details
    Browse the repository at this point in the history

  29. remove the connect default timeout =10

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    0805fda View commit details
    Browse the repository at this point in the history

  30. add support for the terminal use case and some tests

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    873af5f View commit details
    Browse the repository at this point in the history

  31. fix mock status and add the new decorator@

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    7800716 View commit details
    Browse the repository at this point in the history

  32. fix the tests

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6242470 View commit details
    Browse the repository at this point in the history

  33. delete bad comments, add good comments

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    75c397e View commit details
    Browse the repository at this point in the history

  34. ruff

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    35a04ba View commit details
    Browse the repository at this point in the history

  35. feedback response

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6690097 View commit details
    Browse the repository at this point in the history

  36. add return type annotation for testing coverage purposes

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    35b7b9c View commit details
    Browse the repository at this point in the history

  37. respond to feedback

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fb56dc2 View commit details
    Browse the repository at this point in the history

  38. adapt tetramm

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c0bf18d View commit details
    Browse the repository at this point in the history

  39. respond to feedback

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    acbe149 View commit details
    Browse the repository at this point in the history

  40. add repr that includes the config

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5b1b993 View commit details
    Browse the repository at this point in the history

  41. lint

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5ad8f53 View commit details
    Browse the repository at this point in the history

  42. remove old panda ref

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    52b3d22 View commit details
    Browse the repository at this point in the history

  43. fix import

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    d237c77 View commit details
    Browse the repository at this point in the history

  44. fix the tests

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9a5ef37 View commit details
    Browse the repository at this point in the history

  45. pin pyright version due to is_device check failing

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9409b76 View commit details
    Browse the repository at this point in the history

  46. cancel pyright pinning

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    af77a67 View commit details
    Browse the repository at this point in the history

  47. renaming

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    168930d View commit details
    Browse the repository at this point in the history

  48. partial update to fix the test coverage for the factory

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    5492008 View commit details
    Browse the repository at this point in the history

  49. maybe fixed

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    c640721 View commit details
    Browse the repository at this point in the history

  50. imports fix

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    b70f4c9 View commit details
    Browse the repository at this point in the history

  51. fix imports

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    340c7e4 View commit details
    Browse the repository at this point in the history

  52. forgot one

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2f4ce31 View commit details
    Browse the repository at this point in the history

  53. added test to increase coverage, still broken a bit

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3dd4ffe View commit details
    Browse the repository at this point in the history

  54. towards a stable problem definitio a stable problme definition

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    40fa7a6 View commit details
    Browse the repository at this point in the history

  55. fix the test instance

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    dbaabae View commit details
    Browse the repository at this point in the history

  56. finally fixed tests

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f0972b9 View commit details
    Browse the repository at this point in the history

  57. lint

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f7a8f43 View commit details
    Browse the repository at this point in the history

  58. fix tests

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ded7cb9 View commit details
    Browse the repository at this point in the history

  59. exit some tests early

    @stan-dot
    stan-dot committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9cfc9bc View commit details
    Browse the repository at this point in the history