Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added liveness probe commands to use mongo instead of mongosh #91

Merged
merged 3 commits into from
Oct 18, 2022
Merged

added liveness probe commands to use mongo instead of mongosh #91

merged 3 commits into from
Oct 18, 2022

Conversation

rosesyrett
Copy link
Contributor

No description provided.

callumforrester
callumforrester requested changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also do the same for readinessProbe?

helm/diffcalc-api/values.yaml Show resolved Hide resolved
callumforrester
callumforrester approved these changes Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@callumforrester callumforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I haven't tested it

@rosesyrett rosesyrett merged commit e82143b into master Oct 18, 2022
@rosesyrett rosesyrett deleted the fixMongoLivenessProbe branch November 11, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@callumforrester callumforrester callumforrester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosesyrett @callumforrester