Mongo persistence #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 15, 2022 14:49
… Added class variable in stores/protocol to allow specifying error responses related directly to loading/unloading the Hkl object store
…nclude pep8-naming
…n types from services
…ll under a collection, eg several samples may relate to one beamline for example
callumforrester
requested changes
Jul 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage ? 86.31%
=========================================
Files ? 25
Lines ? 519
Branches ? 0
=========================================
Hits ? 448
Misses ? 71
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. |
|
Just a comment - diffcalc-core has now been released with my changes so I no longer need to pull from the branch manually. I'll update this now. Edit: my changes have been merged into master but a new version on pypi hasn't been released yet. So, not sure - am speaking with Irakli about this now. |
garryod
requested changes
Jul 29, 2022
added 2 commits
July 29, 2022 14:33
…ore creation. Seperate PR to follow to take all side effects out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.