Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing routes #111

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Add missing routes #111

merged 2 commits into from
Nov 11, 2022

Conversation

rosesyrett
Copy link
Contributor

Related to DAQ-4373, this PR simply adds some missing routes for adding/getting miscuts, and manually setting U/UB matrices.

Additionally, a small revision to how the TestClient was configured has been made, so that the larger number of tests pass. Previously, one object was modified by the same number of tests.

Rose Yemelyanova added 2 commits November 10, 2022 16:32
…rectly. Also changed ub tests slightly so they do not edit the same objects, and added a fast api config in vscode
@rosesyrett
Copy link
Contributor Author

Also, I moved the 'calculate ub' route from the 'hkl' group to the 'ub' group as this made the most sense to me.

Copy link

@keithralphs keithralphs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really understand the ins and out here, but the code looks reasonable to me.

@rosesyrett rosesyrett merged commit 35745e6 into master Nov 11, 2022
@rosesyrett rosesyrett deleted the addMissingRoutes branch November 11, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants