-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bluesky-stomp and prevent duplication of BasicAuthentication #640
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #640 +/- ##
==========================================
- Coverage 92.66% 92.62% -0.04%
==========================================
Files 35 35
Lines 1663 1654 -9
==========================================
- Hits 1541 1532 -9
Misses 122 122 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
dev-requiremnts need an update |
Fixes #636
Current parsing of config passes a blueapi BasicAuthentication with fields username, passcode as an instance of bluesky-stomp BasicAuthentication with fields username, password. I am not certain that we would be able to pass the former as an instance of the latter even if their arguments agreed, as they are different Pydantic models. We can reuse bluesky-stomp's BasicAuthentication as part of the config of blueapi and not duplicate the logic.