Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIMS-14: Show a direct link to the autoprocessing log #805

Conversation

ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-14

Summary:

Currently it takes 2 clicks to see the processing log, via the "Logs & Files" button. We should add a direct link. We can use the importanceRank field to find the most important file of type 'log'.

Changes:

  • Add a new button to successful autoprocessing jobs saying "Processing Log".
  • Download the first attachment of type 'log' and importanceRank '1'.
  • Sort other attachments by importanceRank first, then alphabetically, instead of random.

To test:

  • Go to a visit, look for a successful fast_dp run, click the "Processing Log" button, check it displays the fast_dp-report.html file
  • Repeat the check for other processing pipelines
  • Check no button appears for unsuccessful processing jobs
  • Check no changes to downstream processing display
  • Click on "Logs & Files", check the first files are those with importanceRank 1 (eg fast_dp-report.html, fast_dp.mtz), then the rest are listed alphabetically.

@ndg63276 ndg63276 requested a review from gfrn July 24, 2024 10:47
@gfrn
Copy link
Collaborator

gfrn commented Jul 25, 2024

At least locally, through the VPN, getting autoproc logs times out when performing the DB query (cm37235-3, page 2, any data collection with valid autoproc). Is there any way we can slim it down?

@gfrn
Copy link
Collaborator

gfrn commented Jul 25, 2024

Doesn't work on my machine, times out. But it works on ispyb-dev-6, so I guess the many VPN hops are affecting file downloads negatively.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2024-R4.3 September 17, 2024 08:55
@ndg63276 ndg63276 merged commit 34022a3 into pre-release/2024-R4.3 Sep 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants