Added an option to hide rooms with zero users. #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
so are you trying to encourage development on this client or what? |
|
Ah, sorry. I was viewing the PR on my phone and it's really easy to hit the close button by accident. I'll take a proper look at it when I get the chance. |
| debugMessage("account->loginHttps() error!"); | ||
| emit loginError(this, "Login Error", QString("%1 (%2)").arg(error_message).arg(error_id)); | ||
| debugMessage("account->loginHttps() error!"); | ||
| if (error_message.compare("Password mismatch.")) { |
There was a problem hiding this comment.
Do we need to hide the error ID for errors that aren't password failures?
|
Okay. Gotten to look at it now. It looks like a decent chunk of the changes will go away if you stick to 4-column tabs for indent, and spaces for alignment, particularly in files already laid out like that. Also, the attempted changes to debugMessage() don't build. That said, the actual feature does work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poked around in the source code out of curiosity this evening, just added an option to the channel list dialogue.