Bugfix/python 3 12 8 #277
Merged
Bugfix/python 3 12 8 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #271. As of Python 3.12.8, shutil.which() will only identify files with an extension listed in the environmental variable PATHEXT. .py files are not in this list by default. python/cpython#127001
line 50 of manager.py uses shutil.which() to locate the full path to huey_consumer.py. Under 3.12.8, this will return None, and ripple with return exit code 1: Error: huey consumer script was not discoverable.
This PR addresses the issue by using the directory of the sys.executable to locate the huey consumer file.
Furthermore, python 3.12.8 appears to be raising an error on an f-string that was not being raised in earlier versions. Taking this opportunity to clean the f-string up.