Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace error messages and add to ERROR_MSGS enum #159

Merged
merged 3 commits into from
Jan 4, 2023

Conversation

oscarsierradevo
Copy link
Contributor

No description provided.

@oscarsierradevo
Copy link
Contributor Author

cryptography 39.0.0 no longer supports openssl 1.1.0 or older and thus is causing this issue. Reference:

@reaperhulk
Copy link

This issue is not caused by dropping 1.1.0, but is instead because the version of pyopenssl you have pinned specifies no upper bounds. As of pyopenssl 22.1 and above pyopenssl specifies a lower and upper bound to avoid incompatibilities with cryptography. I’d suggest bumping the pyopenssl dep and then things will work fine going forward.

@JuanFranDevo
Copy link
Contributor

This issue is not caused by dropping 1.1.0, but is instead because the version of pyopenssl you have pinned specifies no upper bounds. As of pyopenssl 22.1 and above pyopenssl specifies a lower and upper bound to avoid incompatibilities with cryptography. I’d suggest bumping the pyopenssl dep and then things will work fine going forward.

Thanks @reaperhulk ! We will review!

JuanFranDevo
JuanFranDevo previously approved these changes Jan 4, 2023
JuanFranDevo
JuanFranDevo previously approved these changes Jan 4, 2023
@JuanFranDevo JuanFranDevo merged commit d9cba74 into master Jan 4, 2023
@JuanFranDevo JuanFranDevo deleted the replace_error_messages branch January 4, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants