This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Fixed bug where the "stop loss" protection was not triggering #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was simulating. My configuration specifies that:
While simulating I saw this:
This makes no sense, because the stop loss of 1% (c.sell_stop_pct = 1) should have triggered. This is a bug (I think).
I debugged it, and found that:
s.acted_on_stop
is set to true (line 178). As a consequence,s.sell_stop
does not get assigned a value (line 601).s.sell_stop
must have a value (line 157)).Happy holidays ;P