This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
#938, Fixing Error: invalid bucket size spec: undefined #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strategies. There is a callback function in engine.js which sets the options as defined in a strategy. The strategy objects were not updated to have a periodSize option, only a period option. So, the periodSize attribute was not being set. This caused the execption in this bug. This commit adds a second option, named 'periodLength'. The name 'periodLength' was chosen, rather than the previous 'periodSize' for consistency; the description for the --period option already said 'period length', so it made sense that the additional variable be named that as well. Each reference to *.periodSize has been changed to *.periodLength. This commit continues PR DeviaVir#926.
|
@haxwell Thanks for doing this! Do you see changes needed on the backtester scripts? |
|
Thx, now it's all ok ;) |
|
If i use --strategy stddev returns me the same error "Error: invalid bucket size spec: undefined" |
haxwell
added a commit
to haxwell/zenbot
that referenced
this pull request
Dec 21, 2017
strategies. There is a callback function in engine.js which sets the options as defined in a strategy. The strategy objects were not updated to have a periodSize option, only a period option. So, the periodSize attribute was not being set. This caused the execption in this bug. This commit adds a second option, named 'periodLength'. The name 'periodLength' was chosen, rather than the previous 'periodSize' for consistency; the description for the --period option already said 'period length', so it made sense that the additional variable be named that as well. Each reference to *.periodSize has been changed to *.periodLength. This commit continues PR DeviaVir#926 and DeviaVir#940. Third time is the charm :)
haxwell
added a commit
to haxwell/zenbot
that referenced
this pull request
Dec 21, 2017
In testing for PR DeviaVir#940, I discovered that the dependencies necessary to run backtesting were not in package.json. This commit adds them.
haxwell
added a commit
to haxwell/zenbot
that referenced
this pull request
Dec 21, 2017
…ng instances of --period to --periodLength
haxwell
added a commit
to haxwell/zenbot
that referenced
this pull request
Dec 21, 2017
…ng instances of --period to --periodLength
haxwell
added a commit
to haxwell/zenbot
that referenced
this pull request
Dec 21, 2017
…arwin.js genetic backtest. DeviaVir#926 DeviaVir#938 DeviaVir#940
haxwell
added a commit
to haxwell/zenbot
that referenced
this pull request
Dec 21, 2017
…rs, renaming instances of --period to --periodLength
Merged
|
@dsrikanth Thank you for mentioning the backtesters; I didn't know they were there. @efams A likely excuse, I know, but the filter I was using to find where to replace strategy option definitions for --period, missed stddev, and two other strategies. I did a more manual search, to get all the occurrences. I've submitted PR #960 and #961 to address both the above points. Thanks for your patience, everyone. |
DeviaVir
pushed a commit
that referenced
this pull request
Dec 21, 2017
* In addition to the options on a command, there are options on strategies. There is a callback function in engine.js which sets the options as defined in a strategy. The strategy objects were not updated to have a periodSize option, only a period option. So, the periodSize attribute was not being set. This caused the execption in this bug. This commit adds a second option, named 'periodLength'. The name 'periodLength' was chosen, rather than the previous 'periodSize' for consistency; the description for the --period option already said 'period length', so it made sense that the additional variable be named that as well. Each reference to *.periodSize has been changed to *.periodLength. This commit continues PR #926. * In addition to the options on a command, there are options on strategies. There is a callback function in engine.js which sets the options as defined in a strategy. The strategy objects were not updated to have a periodSize option, only a period option. So, the periodSize attribute was not being set. This caused the execption in this bug. This commit adds a second option, named 'periodLength'. The name 'periodLength' was chosen, rather than the previous 'periodSize' for consistency; the description for the --period option already said 'period length', so it made sense that the additional variable be named that as well. Each reference to *.periodSize has been changed to *.periodLength. This commit continues PR #926 and #940. Third time is the charm :) * #926, #938, #940 - In the backtesters, renaming instances of --period to --periodLength * #926, #938, #940 - In the backtesters, renaming instances of --period to --periodLength * Added period and periodLength option, as they were expected for the darwin.js genetic backtest. #926 #938 #940 * #926, #938, #940 - In the (genetic) backtesters, renaming instances of --period to --periodLength
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the options on a command, there are options on
strategies. There is a callback function in engine.js which sets the
options as defined in a strategy. The strategy objects were not
updated to have a periodSize option, only a period option. So,
the periodSize attribute was not being set. This caused the
execption in this bug.
This commit adds a second option, named 'periodLength'. The name
'periodLength' was chosen, rather than the previous 'periodSize' for
consistency; the description for the --period option already said
'period length', so it made sense that the additional variable be named
that as well.
Each reference to *.periodSize has been changed to *.periodLength.
This commit continues PR #926.