This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
[Bitstamp] Fix order completion detection & balance reading during open order. #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 24, 2020
This was referenced Jan 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key fix is for issue #901. Zenbot places an order on bitstamp and doesn't realise it's completed when the order status comes back as "Finished". I've added some logic to change it to "done" when that happens.
When an order completed, the message from zenbot couldn't read the date returned from the API:
sell order completed at Invalid date:Added a bit of logic to map datetime to date, so the engine.js logic can read it properly. Lastly, while an order is open/placed with bitstamp, the current logic read the current balance as 0 and the balance on hold was hardcoded as 0. I've mapped that correctly to x_balance and x_reserved from the bitstamp API response.