This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Some touch-ups to wexnz exchange. #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your branch is up-to-date with 'origin/master'. Changes to be committed: modified: conf-sample.js modified: extensions/exchanges/wexnz/exchange.js modified: package-lock.json modified: package.json ========================================================= package.json: bumped wexnz npm module from 1.0.2 to 1.0.3 to retain v2 api settings for now since our 1.0.2 started at v3, but work will need to be done on a new exchange.js for v3. ========================================================= package-lock.json: routine package-lock.json update for 1.0.3 npm module. ========================================================= conf-sample.js: added a note notifying wex.nz traders that backfilling might not support long-hauls until v2 api limits are raised from 5000 max trades or the tradeHisotry function can be fiured out..... Other exchanges just use "trades" though. ========================================================= exchange.js: A few things, set rate limit to 1, trades count to something over ~9000 to return as many trades as the api possibly can so that the duplicate trade error does not re-occurr at smaller backfills (such as --days=0.1) and while trading at 5000 min periods. exchange.js: Also set authed_client() typo to authedClient() as it should be. ========================================================= Let me know if there is anything else that can be done for now, if any errors occur. I grabbed an API key, it should authenticate fine. @sinister has been authenticating, but might have bugs buying/selling at the moment. Please reply here for any bugs, and I will try my best to iron them out in a few days. JM ~ Sun 03 Dec 2017 05:44:08 AM CST
|
Note: I was able to avoid the duplicate trades error by running this command for trading: BTC may have too many trades for pulling in a day on their exchange right now that is out of their exchange trades pull limit. |
added 4 commits
December 3, 2017 14:06
To account for BTC future prices, increased number format digits.
forgot parenthesis, moved .toLowerCase() UP
Pushed empty col for better spacing.
DeviaVir
approved these changes
Dec 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your branch is up-to-date with 'origin/master'.
Changes to be committed:
modified: conf-sample.js
modified: extensions/exchanges/wexnz/exchange.js
modified: package-lock.json
modified: package.json
package.json: bumped wexnz npm module from 1.0.2 to 1.0.3 to retain v2 api settings for now since our 1.0.2 started at v3, but work will need to be done on a new exchange.js for v3.
package-lock.json: routine package-lock.json update for 1.0.3 npm module.
conf-sample.js: added a note notifying wex.nz traders that backfilling might not support long-hauls until v2 api limits are raised from 5000 max trades or the tradeHisotry function can be figured out..... Other exchanges just use "trades" though.
exchange.js: A few things, set rate limit to 1, trades count to something over ~9000 to return as many trades as the api possibly can so that the duplicate trade error does not re-occurr at smaller backfills (such as --days=0.1) and while trading at 5000 min periods.
exchange.js: Also set authed_client() typo to authedClient() as it should be.
Let me know if there is anything else that can be done for now, if any errors occur. I grabbed an API key, it should authenticate fine. @sinister has been authenticating, but might have bugs buying/selling at the moment.
Please reply here for any bugs, and I will try my best to iron them out in a few days.
JM ~ Sun 03 Dec 2017 05:44:08 AM CST