This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Quadriga CX now supports LTC trading, adding to products #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add amount for takers fee * Minor update to backfill warning text * Fix variable shadowing error * Trades with the same timestamp are now ordered oldest to newest when r eturned from getTrades * Trade volume now returned as number and not a string, prevents NaN on volume report * Filter results on timestamp start to prevent re-reporting the same trades in the results
Some argument about the lack of type safety in javascript.
|
Also added a few more bug fixes related to passing numbers as strings. |
DeviaVir
reviewed
Jul 20, 2017
| "min_size": "0.00001", | ||
| "max_size": "10000", | ||
| "increment": "0.00001", | ||
| "label": "LTC/CAD" |
There was a problem hiding this comment.
is it really just LTC/CAD? No other pairs?
There was a problem hiding this comment.
Yeah. QCX only does CAD currency and no other crypto-to-crypto trading other than ETH-BTC for the moment. But they are fiarly new, so that may change with time.
DeviaVir
approved these changes
Jul 20, 2017
christian452
pushed a commit
to christian452/zenbot
that referenced
this pull request
Jul 27, 2017
* carlos8f-master: Add extension point in dev doc (DeviaVir#395) Removed trailing comma from dependencies. (DeviaVir#398) Updated name of renamed srsi_macd strategy (DeviaVir#400) Quadriga CX now supports LTC trading, adding to products (DeviaVir#392) - Bitfinex and Kraken API throw the "post only" error only on checkOrder(), check for it in engine.js (DeviaVir#391) Windows support (DeviaVir#387) setRawMode is not supported on some remote consoles (no tty) (DeviaVir#380) Fixes for Quadriga CX trading (DeviaVir#386) Only do last sell in simExit when there have been trades (DeviaVir#383)
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
* Quadriga CX Fixes * Add amount for takers fee * Minor update to backfill warning text * Fix variable shadowing error * Trades with the same timestamp are now ordered oldest to newest when r eturned from getTrades * Trade volume now returned as number and not a string, prevents NaN on volume report * Filter results on timestamp start to prevent re-reporting the same trades in the results * Sometime opts.from is undefined, and we should return all results. * Formatting * Quadriga now supports trading LTC * Fixing QCX API handling of numbers Some argument about the lack of type safety in javascript. * QCX fix incorrect error reporting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.