Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Implement a basic MACD strategy #209

Merged
merged 1 commit into from
Jun 3, 2017
Merged

Conversation

dulacp
Copy link
Contributor

@dulacp dulacp commented May 31, 2017

This strategy is very simple, once MACD is computed.

My experiments so far, show that it can be very effective for trading periods of 1h, with a shorter period like 15m it seems too erratic and the Moving Averages are kind of lost. But with 1h period it's performing quite well, even in down trending markets.

Also, it's not firing multiple 'buy' or 'sold' signals, only one per trend, which seems to lead to a better quality trading scheme. Especially when the bot will enter in the middle of a trend, it avoids buying unless it's the beginning of the trend.

I've added a little RSI overbought selling signal too, in case RSI > 70 is true.

Glad to hear your suggestions,
Cheers

Copy link
Owner

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be helpful to update the README.md to mention this new strategy as well.

The code definitely looks great and having tested this in live trading it seems to be very clever. I'm keeping this PR open for a bit more visibility from other folks that might know more about MACD (I would expect more indicators, for one). If there is no feedback after a few more days I'll merge your PR.

@felipecaldas
Copy link

I am adding --strategy macd to the command line but it's not working. Says the strategy does not exist. What am I missing?

@DeviaVir
Copy link
Owner

DeviaVir commented Jun 3, 2017

@felipecaldas don't want to sound mean, but this is not the place for questions like that :) You can create an issue if this really bothers you.
(some simple things you can check; did you check out @dulaccc's branch before attempting to use the strategy?)

@felipecaldas
Copy link

@DeviaVir Can't find anything there that would allow me to use the strategy. Surely I am missing it, just don't know where to look.
Thanks anyway.

@DeviaVir
Copy link
Owner

DeviaVir commented Jun 3, 2017

Actually, @dulaccc, I think it makes more sense to merge your PR as-is now (I will update README) so more people will play with it and can create issues/PR's easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants