Fix spontaneous simulator exits #1971
Conversation
Fixes #1922 by calling `getNext()` based on record count checks rather than the unreliable `.on('end')` cursor event
|
I see that ES6 style code isn't making it through eslint. If you want I can try and rewrite it into ES5. |
@jorisw depends- does it make more sense to switch to ES6 at this point? |
|
I could see that that may be a bit of a big move for zenbot, as indeed all of it has been written in ES5 so far. I personally never write ES5 anymore, and Node 8.3 (the minimum version for zenbot) runs all of my ES6 code without errors. So ideally I suppose this PR needs to go to ES5, after which it could be decided to take the project to ES6. However, as that would constitute a rewrite, that doesn't seem very feasible, therefore you could also simply decide to configure eslint to accept ES6 code, and accept this PR as it is. |
|
Turns out I had |
|
I've ended up setting a modern ECMAScript version in |
* Fix spontaneous bot exits Fixes DeviaVir#1922 by calling `getNext()` based on record count checks rather than the unreliable `.on('end')` cursor event * Set a somewhat recent ECMAScript version * Clean up so eslint passes
* Fix spontaneous bot exits Fixes DeviaVir#1922 by calling `getNext()` based on record count checks rather than the unreliable `.on('end')` cursor event * Set a somewhat recent ECMAScript version * Clean up so eslint passes
* stale[bot] (DeviaVir#1744) * fixing simulation stops after DeviaVir#1971, setImmediate in async function Co-authored-by: Chase <chase@sillevis.net>
Fixes #1922 by calling
getNext()based on record count checks rather than the unreliable.on('end')cursor event.