This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
docker-compose: do not expose mongodb by default! #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very much appreciate this pull!! |
supersabbath
pushed a commit
to supersabbath/zenbot
that referenced
this pull request
Oct 2, 2017
…-docker-expose docker-compose: do not expose mongodb by default!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty important detail for people using docker-compose to deploy their bot on online servers (without default firewall).
There is really no need to expose mongodb at all, since we are internally linking.
I could imagine there are quite a few installations that are currently exposing their mongodb to the outside world, unknowingly.