-
Notifications
You must be signed in to change notification settings - Fork 2k
Improvement/typescript refactor #1656
Improvement/typescript refactor #1656
Conversation
Bloody good work! This looks leaps and bounds better |
Thinking on creating a zenbot.ts and renaming this repo to zenbot.js and seeing which one gets more traction and further development to nominate that one as the default for |
@@ -39,3 +39,4 @@ gen.*.bat | |||
gen.*.sh | |||
.env | |||
scripts/auto_backtester/backtesting_*.csv | |||
.vscode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind, but you could also add this to your global gitignore locally.
@DeviaVir Splitting them out kinda makes sense but why not a separate branch? Easier to cherry pick changes applicable to both? |
Already discussed with @DeviaVir on discord, but just wanted to put this down here as well. I'm thinking a new branch would be the best way to go. A new repo will, for one, be at a disadvantage since all the stars and followers will be reset; it will create the need to maintain feature parity between the two projects which will inevitably succumb to piles of technical debt. In case there's a huge backlash against typescript there's always the option of transpiling the source to plain JS. All we'd have to do is run Ultimately, I want this project to be badass. There's huge potential here. I don't have a dogmatic preference on which language is used, I just think TS would be a huge benefit here and it'll become clear once I'm done with this refactoring. p.s. I've started work on state management last night and re-architecting the data schema. This change is going to break most backward compatibility (unless we create a migration script) but it introduces an immutable and observable state tree, which is nice especially in comparison to passing around the |
@notVitaliy Nice work, i'm working with TypeScript as well. Is the TS Version up2date? Can we progress on this ? |
@notVitaliy I also think that the move to TS will bring some new life in the project. As per today TS is the standard in the JS world. Do you have any update on this? I notice as per today this branch is 688 commits behind unstable. |
@notVitaliy Sick! I will have a look at it and hopefully contribute if possible. Let's keep in contact! |
See #1652