This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Resize order on reorder #1406
Merged
Resize order on reorder #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of reordering using the same size (which doesn't make sense) calculate the (remaining) size (in percent) of the order and use it as `buy|sell_pct` This should fix a fair ammount of "insufficient funds" errors people have been reporting.
DeviaVir
approved these changes
Feb 22, 2018
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of reordering using the same size (which doesn't make sense) calculate the (remaining) size (in percent) of the order and use it as
buy|sell_pctThis should fix a fair ammount of "insufficient funds" errors people have been reporting.
e.g. #1223 #1315 & #1392 and possible even one of thus older ones including #699 #820 #876 #900 & #910