This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Multiple API & Web UI improvements #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
defkev
commented
Jan 19, 2018
•
defkev
commented
- Add momentjs (mainly for date/time humanization)
- More precise bot uptime (seconds, minutes, hours, days instead of just days)
- Display trading chart in server time (for consistence with "My Trades" dates)
- Reduce default trading chart range to 30 minutes (from 60)
- Sort "My Trades" by date (descending)
- Change "Executed Date" to "Execution Time"
- Reduce memory util if API is off
- Add Total to My Trades
- API: Populate stats on every new period
- Color profits (last balance and buy hold) green/red based on win/loss
- Use singular and plural for trade(s) and day(s)
- Fix chart 1 hour range selector button
- Rename "Asset / Currency" widget to "Capital" and move it up to Market row
- Remove leading space from "Last Balance" widget
- Add "Error Rate" widget including Win/Loss
- Format open order dates like complete
- Fix Market/Capital row layout on mobile
- API: Always calculate fees
- API: Add profit calculation (buy/sell, sell/buy) to my_trades, profit won't be calculated unless there was a previous opposide order (buy profit on previos sell, sell profit on previous buy)
- Add Fee and Profit column to My Trades
- Normalize number formating for consistence and to remove clutter
|
@defkev Since you worked on this page already, do you think you can add a column in "My trades" for the "Total" (total = amount * price)? That would be useful to have. |
|
Good idea @firepol 👍 |
DeviaVir
previously requested changes
Jan 21, 2018
|
Yup, Jasmine is not aware of Update |
defkev
force-pushed
the
pr-webui-date-and-time
branch
from
ed86c56
to
06f8cae
Compare
defkev
added a commit
to defkev/zenbot
that referenced
this pull request
Jan 22, 2018
|
Merge #1204 and rerun the tests. |
defkev
added a commit
to defkev/zenbot
that referenced
this pull request
Jan 22, 2018
defkev
added a commit
to defkev/zenbot
that referenced
this pull request
Jan 22, 2018
Can't fool Travis 🔨
defkev
added a commit
to defkev/zenbot
that referenced
this pull request
Jan 22, 2018
Can't fool Travis 🔨
defkev
changed the title
DeviaVir
pushed a commit
that referenced
this pull request
Jan 23, 2018
|
@defkev would you mind pulling in latest changes from |
* Add momentjs (mainly for date/time humanization) * More precise bot uptime (seconds, minutes, hours, days instead of just days) * Display trading chart in server time (for consistence with "My Trades" dates) * Reduce default trading chart range to 30 minutes (from 60) * Sort "My Trades" by date (descending) * Change "Executed Date" to "Execution Time"
Total = Size * Price
Populate objects used exclusively by the API only if the API is actually enabled.
* Color profits (last balance and buy hold) green/red based on win/loss * Use singular and plural for trade(s) and day(s) * Fix chart 1 hour range selector button
Instead of having to manually "print statistical output" in the console to get them updated.
* Rename "Asset / Currency" widget to "Capital" and move it up to Market row * Remove leading space from "Last Balance" widget * Limit "vs buy hold" to 10 digits * Add "Error Rate" widget including Win/Loss
Looks like i forgot something...
* API: Add profit calculation (buy/sell, sell/buy) to my_trades, profit won't be calculated unless there was a previous opposide order (buy profit on previos sell, sell profit on previous buy) * Web UI: Add Fee and Profit column (Closes DeviaVir#1192) * Normalize number formating for consistence and to remove clutter
defkev
force-pushed
the
pr-webui-date-and-time
branch
from
06f8cae
to
b354f21
Compare
|
Done |
This was referenced Apr 13, 2021
This was referenced Apr 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.