Fix multiple notifications at once bug #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerpentBytes
added
bug
humphd
reviewed
Apr 25, 2023
* attempt to make exipiration notifications work * remove unused constant * update condition for the dnsRecords query * add comments
humphd
approved these changes
Apr 26, 2023
|
I am not running into issues with certificate failure yielding duplicate notifications locally:
|
|
We only run a single instance locally, so we should do this and test in staging. I'm going to merge this so people can test, and we'll iterate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #650 by making adjustments to expiration notification-related code for DNS records and Certificates. Attempts to fix the annoying bug of getting too many notifications at once regarding expiring records.
It seems like the root cause of getting multiple notifications was because we were checking if
lastNotifiedis set tonullORlastNotifiedis set to date, which is 30 days in the past. Since we are sending one reminder for now, we don't need to verify whether it has been a month since we last notified the user.Steps to test
npm run db:studioand set the expiration date to a month in the future