Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] #45 - 편집 모달 뷰 에니메이션 에러 수정 #54

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

YunSeok-Choi
Copy link
Collaborator

Keychanges

  • 앱 처음 실행 시, 글 작성 후 RecordDetailView에서 편집을 눌렀을 때 나오는 뷰가 애니메이션 동작하지 않는 부분을 수정하였습니다.

Screenshots

iPhone13, 화면이름
Simulator Screen Recording - iPhone 14 - 2022-09-25 at 22 59 50

To Reviewer

토글하는 변수에 didSet과 willSet을 이용하였습니다

@YunSeok-Choi YunSeok-Choi added the 🐛 bug Something isn't working label Sep 25, 2022
@YunSeok-Choi YunSeok-Choi added this to the Record version1.0.0 milestone Sep 25, 2022
@YunSeok-Choi YunSeok-Choi self-assigned this Sep 25, 2022
@YunSeok-Choi YunSeok-Choi linked an issue Sep 25, 2022 that may be closed by this pull request
Copy link
Member

@JMM00 JMM00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

willSet 속성을 사용하면 해결되는군요...! 잘 배워갑니다~!!!

Copy link
Collaborator

@mxnxxii mxnxxii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

융식최고~ 멋쨍이! 확인했씁니닷

Comment on lines +24 to +32
@State private var clickEdit = false {
willSet {
UIView.setAnimationsEnabled(true)
} didSet {
DispatchQueue.main.async {
UIView.setAnimationsEnabled(true)
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH!
혹시 왜 속성 감시자를 사용하면 해결되는지 알 수 있을까요!?
정말 궁금했던 내용이어서 궁금하네요~! 🔥

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swiftUI 오류라고 생각되는데, 정확하게 애니메이션 값을 설정해 주지 않아서 발생하는 것 같아요!
WirteView에서 didAppear 메소드안에 똑같이 애니메이션 값을 설정해 주면 완벽하게 해결되지 않아서
willSet과 didSet을 이용해주었습니다!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배워가유 ~~~

Copy link
Collaborator

@Eunbi-Cho Eunbi-Cho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

willSet과 didSet을 이럴때 사용하는군요! 👍🏻👍🏻

@JIWON1923 JIWON1923 merged commit a4c5246 into develop Sep 27, 2022
@JIWON1923 JIWON1923 deleted the RecordDetailView/Editing branch September 27, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fix] 편집 모달 뷰 애니메이션 에러
5 participants