[#94] 사용자의 애플 뮤직 구독 관리 #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 사용자의 애플 뮤직 구독 상태를 관리하는 manager 생성 - 구독하지 않은 사용자의 경우, - 온보딩 이후 or 홈 화면 진입 시에 애플에서 제공하는 구독 권유 sheet가 뜬다.
2 tasks
zaehorang
reviewed
Jun 12, 2024
| import MusicKit | ||
| import SwiftUI | ||
|
|
||
| class SubscriptionManager: ObservableObject { |
There was a problem hiding this comment.
final 키워드를 안 붙이신 이유가 있을까요?
| class SubscriptionManager: ObservableObject { | ||
| static let shared = SubscriptionManager() | ||
|
|
||
| @State var musicSubscription: MusicSubscription? |
There was a problem hiding this comment.
State 변수로 선언하신 이유가 있을까요?
| @@ -14,8 +14,10 @@ struct HomeView: View { | |||
| @StateObject private var musicPersonalRecommendationModel = MusicPersonalRecommendationModel() | |||
| // 지난 선곡 데이터를 위한 모델 | |||
| @StateObject private var selectedMusicDataModel = TrackIDConverter() | |||
| @ObservedObject var subscriptionManager = SubscriptionManager.shared | |||
There was a problem hiding this comment.
@ StateObject로 선언하는 건 어떨까요?
| } | ||
| .task { |
There was a problem hiding this comment.
SubscriptionManager에서 메서드로 작성한 기능과 같은 거 같은데 없어도 되는 거 같은데..
맞나용? 🐯
- 사용자의 애플 뮤직 구독 상태 관리
- 현재 다크모드 배경 문제로 라이트모드만 사용 가능하도록 설정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
스크린샷
💬 리뷰 요구사항(선택)