Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to yarn dev in CONTRIBUTING.md #43

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Remove reference to yarn dev in CONTRIBUTING.md #43

merged 1 commit into from
Nov 30, 2021

Conversation

swellander
Copy link
Contributor

This is to keep the CONTRIBUTING.md file up to date, removing the reference to yarn dev which no longer exists.

@DavidVanDrei
Copy link

I think you should mention the need to run yarn build before storybook

@swellander
Copy link
Contributor Author

@RoguePenguins good call 👍

@swellander
docs: remove reference to yarn dev
919eddf 
Replaces with existing storybook scripts
etr2460
etr2460 approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the docs fix! i know this has been in flux quite a bit, so thanks for being patient with out of date instructions 😅

@etr2460 etr2460 merged commit 25b43bd into Developer-DAO:master Nov 30, 2021
@swellander
Copy link
Contributor Author

@etr2460 no problem at all! Exciting to see the bustling activity 🏙️

@swellander swellander deleted the fix/contributing.md branch November 30, 2021 23:32
@Dhaiwat10
Copy link
Member

@allcontributors add @swellander for documentation

@allcontributors allcontributors bot mentioned this pull request Dec 7, 2021
Merged
@allcontributors
Copy link
Contributor

@Dhaiwat10

I've put up a pull request to add @swellander! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etr2460 etr2460 etr2460 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swellander @DavidVanDrei @Dhaiwat10 @etr2460