Spread ChakraProvider props to Provider Component

[Ibby-devv]

Closes #137

Description

Spread built in ChakraProviderProps to Provider Component.

[changeset-bot]

🦋 Changeset detected

Latest commit: 7525f80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@web3-ui/components	Minor
@web3-ui/core	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[with-heart]

This makes me wonder if we should just get rid of the Provider component entirely until we have a reason for it. It's not doing anything except wrapping ChakraProvider.

[with-heart]

For some reason the GitHub suggestions interface is bugging out when I try to select multiple lines so I'll have to spread the suggestions across multiple comments 😬

Since we're already using interface here, we can use extends to clean this up a bit.

Suggested change

	export interface ProviderProps {}
	export interface ProviderProps extends ChakraProviderProps {}

[with-heart]

Then we don't need to use an intersection here since the type is already tied into ProviderProps.

Suggested change

	export const Provider: React.FC<ProviderProps & ChakraProviderProps> = ({ children, ...props }) => {
	export const Provider: React.FC<ProviderProps> = ({ children, ...props }) => {

[Ibby-devv]

This makes me wonder if we should just get rid of the Provider component entirely until we have a reason for it. It's not doing anything except wrapping ChakraProvider.

Agree, not sure what the Provider is used for. If we need the ChakraProvider, why not just use it directly?

[Dhaiwat10]

This makes me wonder if we should just get rid of the Provider component entirely until we have a reason for it.

If we don't have a Provider that basically wraps everything inside the ChakraProvider, anyone wanting to use our library properly would have to install and set up Chakra UI themselves. I don't think we would want that.

[Dhaiwat10]

If we need the ChakraProvider, why not just use it directly?

That's what we are doing! We're just indirectly shipping it as our own provider. We're assuming that not everyone using this package needs to be educated about Chakra.

[Ibby-devv]

If we need the ChakraProvider, why not just use it directly?

That's what we are doing! We're just indirectly shipping it as our own provider. We're assuming that not everyone using this package needs to be educated about Chakra.

What I meant was our Provider could simply use the ChakraProvider directly until we have something more to add to it.

[Dhaiwat10]

@Ibby-devv that's precisely what it's doing right now, I think. I am aware that we could just directly export the ChakraProvider as our own Provider but I prefer having a separate file and declaration like this. Purely my opinion though.

[Ibby-devv]

@Ibby-devv that's precisely what it's doing right now, I think. I am aware that we could just directly export the ChakraProvider as our own Provider but I prefer having a separate file and declaration like this. Purely my opinion though.

Yeah that's fair enough. I'm on my phone so not sure if the changes I made were what you were looking for in terms of passing on the props to our component.

[Dhaiwat10]

I merged them in, they're fine!