(chore) - remove extraneous deps #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ec294ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Oh... We rely on actual fetching in our unit tests 😅 |
We have mocked the response though. Can we not do something about it? :( |
|
yea fixed it with just polyfilling in the test-setup @Dhaiwat10 |
JoviDeCroock
commented
Dec 22, 2021
| @@ -47,7 +46,9 @@ export const NFT = ({ contractAddress, tokenId, size = 'xs' }: NFTProps) => { | |||
|
|
|||
| const fetchNFTData = useCallback(async () => { | |||
| try { | |||
| const res = await fetch(`https://api.opensea.io/api/v1/asset/${contractAddress}/${tokenId}/`); | |||
| const res = await fetch( | |||
There was a problem hiding this comment.
Most of these formatting changes are due to the lint-staged not actually applying correctly before it seems
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145
Closes #128
Description
This removes the extraneous
@emotion/core,cross-fetchandclassnamesdeps