Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading state of useTransaction and refactor story #146

Merged
merged 3 commits into from
Dec 22, 2021

Conversation

Dhaiwat10
Copy link
Member

@Dhaiwat10 Dhaiwat10 commented Dec 22, 2021

  • The useTransaction hook wasn't waiting for the transaction to be confirmed before setting loading as false.
  • I have also re-factored the story for the hook to use Form elements.
  • Updated the docstrings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2021

🦋 Changeset detected

Latest commit: a357c2f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web3-ui/hooks Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Dhaiwat10 Dhaiwat10 merged commit 169021d into main Dec 22, 2021
@Dhaiwat10 Dhaiwat10 deleted the fix/use-transaction branch December 22, 2021 13:08
This was referenced Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant