Address should not use input element #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 18, 2021 09:33
…ess - we are now using Text - removed onclick types as we are not using event argument anymore
🦋 Changeset detectedLatest commit: 0fcd56d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Dhaiwat10
reviewed
Dec 18, 2021
| @@ -38,20 +38,19 @@ describe('Address copiable prop true', () => { | |||
|
|
|||
| it('uses writeText from Clipboard API', async () => { | |||
| const { container } = render(<Address copiable value='taylorswift.eth' />); | |||
| const input = container.querySelector('input') as HTMLElement; | |||
| const addressContainer = getByTestId(container, 'address-container'); | |||
There was a problem hiding this comment.
Curious why did you go for getByTestId instead of getByText?
Merged
|
@allcontributors add @maximebonhomme for code |
|
I've put up a pull request to add @maximebonhomme! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124
Description
Updated the Address component to use
TextChakraUI component instead of unnecessaryInputcomponent.📝 Additional Information
It currently doesn't have any styling. It's up to the user to wrap it inside a styled container. I reckon let's wait until we have a design system before making a styled version of Address component?