Fix NFT sizes and add docs #130
Conversation
🦋 Changeset detectedLatest commit: e44c161 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
etr2460
force-pushed
the
fix-nft-gallery
branch
from
18915dc to
13dd8e2
Compare
| } catch (error: any) { | ||
| setErrorMessage(error.message); | ||
| } catch (error) { | ||
| if (error instanceof Error) { |
There was a problem hiding this comment.
Could be good to create a helper for this as we're handling errors in quite a few places. What do you reckon? Can add a separate ticket for this.
There was a problem hiding this comment.
Makes sense. It seems like we're handling errors (and the typing of them) in a couple ways. I'll make an issue to figure out the best way to handle errors in our code, and use whatever helper function i make across the codebase
There was a problem hiding this comment.
@maximebonhomme feel free to create that ticket. Good suggestion
|
@etr2460 looks good. Can you add a changeset by running |
|
Thanks for adding the changeset @Dhaiwat10. do you have docs around when to do a minor vs. a patch changeset? This PR was mainly a fix, although it did add a new (optional) prop to the NFT component |
|
@etr2460 no I don't think we have any proper documentation around that. Do you think we need it? |
Closes #94
Description
Attempts to ensure all nft cards are squares of the same size. Also adds some more docs
Screenshot
to: @Dhaiwat10