Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9999600-java-long-method-fixer #829

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

9999600-java-long-method-fixer #829

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 32 additions & 23 deletions core/src/main/java/hudson/model/Items.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,33 +253,42 @@ public static String getCanonicalName(ItemGroup context, String path) {
String[] c = context.getFullName().split("/");
String[] p = path.split("/");

Stack<String> name = new Stack<>();
for (int i=0; i<c.length;i++) {
if (i==0 && c[i].equals("")) continue;
name.push(c[i]);
}
Stack<String> name = getName(c); // CAP AL
for (int i=0; i<p.length;i++) {
if (i==0 && p[i].equals("")) {
// Absolute path starting with a "/"
name.clear();
continue;
}
if (p[i].equals("..")) {
if (name.size() == 0) {
throw new IllegalArgumentException(String.format(
"Illegal relative path '%s' within context '%s'", path, context.getFullName()
));
}
name.pop();
continue;
}
if (p[i].equals(".")) {
continue;
}
name.push(p[i]);
extractedMethod10(context, i, name, p, path); // CAP AL
}
return StringUtils.join(name, '/');
}
// CAP AL
private static Stack<String> getName(final String[] c) { // CAP AL
Stack<String> name = new Stack<>(); // CAP AL
for (int i=0; i<c.length;i++) { // CAP AL
if (i==0 && c[i].equals("")) continue; // CAP AL
name.push(c[i]); // CAP AL
} // CAP AL
return name; // CAP AL
} // CAP AL
// CAP AL
private static void extractedMethod10(final ItemGroup context, final int i, final Stack<String> name, final String[] p, final String path) { // CAP AL
if (i==0 && p[i].equals("")) { // CAP AL
// Absolute path starting with a "/" // CAP AL
name.clear(); // CAP AL
continue; // CAP AL
} // CAP AL
if (p[i].equals("..")) { // CAP AL
if (name.size() == 0) { // CAP AL
throw new IllegalArgumentException(String.format( // CAP AL
"Illegal relative path '%s' within context '%s'", path, context.getFullName() // CAP AL
)); // CAP AL
} // CAP AL
name.pop(); // CAP AL
continue; // CAP AL
} // CAP AL
if (p[i].equals(".")) { // CAP AL
continue; // CAP AL
} // CAP AL
name.push(p[i]); // CAP AL
} // CAP AL

/**
* Computes the relative name of list of items after a rename or move occurred.
Expand Down