-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add possibility to pass additional data to the reporter plugin (closes #3584) #7562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artem-Babich
force-pushed
the
report-api
branch
from
March 15, 2023 10:26
9ea7a92
to
55a2543
Compare
Artem-Babich
changed the title
feat: add possibility to pass additional data to the reporter plugin
feat: add possibility to pass additional data to the reporter plugin (closes #3584)
Mar 15, 2023
miherlosev
suggested changes
Mar 16, 2023
test/functional/fixtures/reporter/testcafe-fixtures/report-data-test.js
Outdated
Show resolved
Hide resolved
Artem-Babich
force-pushed
the
report-api
branch
from
March 17, 2023 11:56
f1ad440
to
b3b584e
Compare
Artem-Babich
force-pushed
the
report-api
branch
from
March 21, 2023 07:10
39dfe7d
to
d3cdb5a
Compare
miherlosev
suggested changes
Mar 21, 2023
test/functional/fixtures/reporter/testcafe-fixtures/report-data-test.js
Outdated
Show resolved
Hide resolved
miherlosev
approved these changes
Mar 23, 2023
Release v2.5.0-rc.1 addresses this. |
2 tasks
aleks-pro
pushed a commit
that referenced
this pull request
Apr 4, 2023
<!-- Thank you for your contribution. Before making a PR, please read our contributing guidelines at https://github.com/DevExpress/testcafe/blob/master/CONTRIBUTING.md#code-contribution We recommend creating a *draft* PR, so that you can mark it as 'ready for review' when you are done. --> ## References #7562 ## Pre-Merge TODO - [ ] Write tests for your proposed changes - [ ] Make sure that existing tests do not fail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#3584
A lot of users need to pass additional information from the test to the custom or existing reporter.
Aproach
This is the first part of reporter improvements that allow users to pass additional data to the reporter by running t.report action.
This action triggers reportData reporter event as well as adds passed data to the testRun. Finally this data is passed to the reportTestDone event handler.
API:
TestController:
ReporterPlugin
References
#3584
DevExpress/testcafe-reporter-spec#8
Pre-Merge TODO