Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix scroll position for cdp events #7559

Merged
merged 3 commits into from
Mar 15, 2023
Merged

Conversation

AlexKamaev
Copy link
Contributor

@AlexKamaev AlexKamaev commented Mar 10, 2023

calculate leftTopPoint on demand before making request to the cdp route
remove leftTopPoint passing from all other places

this PR fixes the #7557 issue only partially because, there is another problem with fixed header + iframes + proxyless, which is specific to the DevExtreme website

@AlexKamaev AlexKamaev temporarily deployed to CI March 10, 2023 14:09 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI March 14, 2023 11:28 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI March 14, 2023 11:44 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev temporarily deployed to CI March 14, 2023 11:49 — with GitHub Actions Inactive
@AlexKamaev AlexKamaev requested a review from miherlosev March 14, 2023 12:43
@AlexKamaev AlexKamaev marked this pull request as ready for review March 14, 2023 12:43
@miherlosev miherlosev merged commit 31b74be into DevExpress:master Mar 15, 2023
@github-actions
Copy link

Release v2.5.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants