Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix request API protocol in proxyless #7556

Merged
merged 2 commits into from
Mar 7, 2023

Conversation

Artem-Babich
Copy link
Contributor

@Artem-Babich Artem-Babich commented Mar 7, 2023

Purpose

Currently protocol is hardcoded to http when sending requests with request API in proxyless

Approach

Use request URL protocol

References

Provide a link to the existing issue(s), if any.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@Artem-Babich Artem-Babich temporarily deployed to CI March 7, 2023 07:36 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich temporarily deployed to CI March 7, 2023 13:56 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich force-pushed the fix-request-protocol branch from 83bf514 to af34ff6 Compare March 7, 2023 13:57
@Artem-Babich Artem-Babich temporarily deployed to CI March 7, 2023 13:57 — with GitHub Actions Inactive
@Artem-Babich Artem-Babich requested a review from miherlosev March 7, 2023 13:58
@Artem-Babich Artem-Babich merged commit 721ce45 into DevExpress:master Mar 7, 2023
@Artem-Babich Artem-Babich deleted the fix-request-protocol branch March 7, 2023 15:43
@github-actions
Copy link

Release v2.5.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants