Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Selector Inspector): selectors parsing in experimental debug mode #7517

Merged
merged 4 commits into from
Feb 17, 2023
Merged

fix(Selector Inspector): selectors parsing in experimental debug mode #7517

merged 4 commits into from
Feb 17, 2023

Conversation

felis2803
Copy link
Contributor

@felis2803 felis2803 commented Feb 16, 2023 •
edited
Loading

In experimental debug mode, the TestRun instance has a controller field of null. Because of this, it was impossible to get the context in which the selector is executed.

Steps to reproduce

  1. Run Selector Inspector in experimental debug mode.
  2. Enter selector in css format - the match indicator should show the correct number of elements.
  3. Enter selector in TestCafe format - the match indicator should show the correct number of elements.

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

@felis2803 felis2803 temporarily deployed to CI February 16, 2023 07:28 — with GitHub Actions Inactive
@felis2803 felis2803 temporarily deployed to CI February 16, 2023 07:32 — with GitHub Actions Inactive
@felis2803 felis2803 self-assigned this Feb 16, 2023
@felis2803 felis2803 temporarily deployed to CI February 16, 2023 08:02 — with GitHub Actions Inactive
@felis2803 felis2803 temporarily deployed to CI February 17, 2023 09:25 — with GitHub Actions Inactive
@felis2803 felis2803 enabled auto-merge (squash) February 17, 2023 11:24
@felis2803 felis2803 requested a review from AlexKamaev February 17, 2023 14:12
@felis2803 felis2803 merged commit d8fd333 into DevExpress:master Feb 17, 2023
@felis2803 felis2803 deleted the si-debug branch February 17, 2023 14:18
@felis2803
Copy link
Contributor Author

felis2803 commented Feb 17, 2023 •
edited
Loading

It is necessary to restore the start of Selector Inspector tests in experimental debug mode.
https://github.com/DevExpress/testcafe-private/issues/103

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Release v2.4.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexKamaev AlexKamaev AlexKamaev approved these changes

Assignees

@felis2803 felis2803

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felis2803 @AlexKamaev