Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix Screenshots in macOS Safari - adapt to rounded corners (#8161)
## Purpose #8154 addresses the issue, where screenshots are not cropped on macOS (14) Safari. The problem is, that the screenshot mark can not be found. This is because part of the mark is not visible because of the rounded corners in macOS. ![312752882-4a8a5548-85e3-4805-855e-608366c74c8b](https://github.com/DevExpress/testcafe/assets/2182288/be53f18f-be1a-41ce-b432-26b68aa561e4) ## Approach The solution is to increase `MARK_RIGHT_MARGIN` in `src/screenshots/constants.js`. I found that `25` is the lowest value that works for all resolutions I was able to test. * In order for the tests to work I parametrized the tests to depend on `MARK_RIGHT_MARGIN`. * ~~I enabled the screenshot-tests that were skipped in the safari browser~~ * ~~fix tests~~ * ~~retina aware~~ * ~~color-profile aware~~ ## References #8154 ## Pre-Merge TODO - [x] Write tests for your proposed changes - [x] Make sure that existing tests do not fail --------- Co-authored-by: gti <support@gti.de>
- Loading branch information