Skip to content

Commit

Permalink
fix: job reporting tests in proxyless (#7534)
Browse files Browse the repository at this point in the history
## Purpose
Job Reporting tests do not work in proxyless
## Approach
Pass proxyless settings to the browserProvider mock

## Pre-Merge TODO
- [ ] Make sure that existing tests do not fail
  • Loading branch information
Artem-Babich authored Feb 24, 2023
1 parent 53b37eb commit 8ef9b0a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
1 change: 0 additions & 1 deletion gulp/constants/functional-test-globs.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ const DEBUG_GLOB_2 = [
const PROXYLESS_TESTS_GLOB = [
...TESTS_GLOB,
'!test/functional/fixtures/ui/test.js',
'!test/functional/fixtures/browser-provider/job-reporting/test.js',
'!test/functional/fixtures/driver/script-execution-barrier/test.js',
'!test/functional/fixtures/run-options/request-timeout/test.js',
'!test/functional/fixtures/run-options/disable-page-caching/test.js',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if (config.useLocalBrowsers && !config.hasBrowser('ie')) {
state: {},
idNameMap: {},

openBrowser (browserId, pageUrl, browserConfig) {
openBrowser (browserId, pageUrl, browserConfig, additionalOptions) {
const self = this;
const providerId = typeof browserConfig ===
'string' ? browserConfig : browserConfig.userArgs.replace(/\W*/, '');
Expand All @@ -37,7 +37,7 @@ if (config.useLocalBrowsers && !config.hasBrowser('ie')) {
userArgs: `--no-sandbox ${browserConfig.userArgs}`,
headless: true,
},
{ disableMultipleWindows: false });
{ ...additionalOptions, disableMultipleWindows: false });
},

closeBrowser (browserId) {
Expand Down

0 comments on commit 8ef9b0a

Please sign in to comment.