Made '--debug-brk' parameter optional to be able run testcafe on Electron > 19

[lenchvolodymyr]

--debug-brk was deprecated since nodejs 7.7.0 and in electron 1.7.4 was added a support for --inspect. In Electron 19 --debug-brk was supressed and no longer works, which leads to an error: "Unable to connect".

I added a new option enableDebug that allows using an old parameter --debug-brk for Electron < 1.7.4 and use --inspect by default for newer Electron versions.

Related issue: #90

[github-actions]

Thank you for your contribution to TestCafe. We will review this PR.

[miherlosev]

I don't think we need an extra option.
You can calculating the module logic depending on Electron version:

• if Electron < 19, use the old behavior (the --debug-brk=<port> will be used`).
• if Electron >= 19, use the --inspect-brk=${ports[1]} parameter.

[lenchvolodymyr]

I thought about it, but how can I get the electron version?

[miherlosev]

We have a few ideas on how to implement it in another way. We will check them and update this thread as soon we have any news.

[vlad-dargel]

@miherlosev any news here?

[lenchvolodymyr]

if someone needs this update urgently, you can install it from fork, but hope changes will be released soon
npm i github:hackolade/testcafe-browser-provider-electron#feat/v0.0.19

[AndreyBelym]

Hi @lenchvolodymyr! Thank you for your contribution. I discussed your PR with the team and we decided we should drop supporting older Electron versions that use the --debug-brk switch. This way there is no need for an additional option in the config. Please let me know if you are interested in reworking your PR. Otherwise, team members can do it in the next several weeks.

[lenchvolodymyr]

Hi @AndreyBelym , this even better:

we decided we should drop supporting older Electron versions

I'll update PR soon

[lenchvolodymyr]

@AndreyBelym it's done

[miherlosev]

Hi @lenchvolodymyr,

Thank you for your work. We will review it.