Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove luxon and es6-object-assign #14825

Merged
merged 5 commits into from
Oct 9, 2020

Conversation

San4es
Copy link
Contributor

@San4es San4es commented Oct 6, 2020

These libs were necessary for rrule v2.6.4 (see jkbrzt/rrule#344 and jkbrzt/rrule#402). But starting with v2.6.6 it is no need to include them (see https://github.com/jakubroztocil/rrule/releases/tag/v2.6.6 and jkbrzt/rrule#410).

This PR updates rrule to v2.6.6 and removes luxon and es6-object-assign libs from our dependencies as not necessary now.

@San4es San4es added the 20_2 label Oct 6, 2020
@San4es San4es self-assigned this Oct 6, 2020
@San4es San4es force-pushed the remove-luxon-and-object-assign branch from af6f568 to 76408a8 Compare October 8, 2020 12:01
@San4es San4es marked this pull request as ready for review October 8, 2020 13:13
NOTICE.txt Show resolved Hide resolved
@DokaRus
Copy link
Contributor

DokaRus commented Oct 8, 2020

@San4es Object.assign and extend works slightly different.
E.g. merge two objects: { name: 'a' } and { name: undefined }:
image

Won't there be an unexpected change in behavior?

@San4es
Copy link
Contributor Author

San4es commented Oct 8, 2020

@DokaRus

Thanks for your remark! I think we need to check this in each case.

@San4es San4es merged commit 018c6ca into DevExpress:20_2 Oct 9, 2020
@San4es San4es deleted the remove-luxon-and-object-assign branch October 9, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants