-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove luxon and es6-object-assign #14825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
San4es
force-pushed
the
remove-luxon-and-object-assign
branch
from
October 8, 2020 12:01
af6f568
to
76408a8
Compare
San4es
requested review from
AntonSermyazhko,
Yarovaya,
DokaRus and
andrewmakarov
October 8, 2020 13:13
San4es
commented
Oct 8, 2020
San4es
commented
Oct 8, 2020
AntonSermyazhko
approved these changes
Oct 8, 2020
@San4es Won't there be an unexpected change in behavior? |
San4es
commented
Oct 8, 2020
San4es
commented
Oct 8, 2020
Thanks for your remark! I think we need to check this in each case. |
Yarovaya
approved these changes
Oct 9, 2020
DokaRus
approved these changes
Oct 9, 2020
MaximKudriavtsev
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These libs were necessary for rrule v2.6.4 (see jkbrzt/rrule#344 and jkbrzt/rrule#402). But starting with v2.6.6 it is no need to include them (see https://github.com/jakubroztocil/rrule/releases/tag/v2.6.6 and jkbrzt/rrule#410).
This PR updates rrule to v2.6.6 and removes luxon and es6-object-assign libs from our dependencies as not necessary now.