Scheduler - RRule integration #13232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonSermyazhko
requested review from
Yarovaya,
andrewmakarov and
AryamnovEugeniy
Yarovaya
reviewed
May 28, 2020
testing/tests/DevExpress.ui.widgets.scheduler/integration.recurringAppointments.tests.js
Outdated
Show resolved
Hide resolved
Yarovaya
reviewed
May 28, 2020
testing/tests/DevExpress.ui.widgets.scheduler/integration.recurringAppointments.tests.js
Outdated
Show resolved
Hide resolved
Yarovaya
reviewed
May 28, 2020
testing/tests/DevExpress.ui.widgets.scheduler/integration.recurringAppointments.tests.js
Outdated
Show resolved
Hide resolved
Yarovaya
reviewed
May 28, 2020
testing/tests/DevExpress.ui.widgets.scheduler/integration.recurringAppointments.tests.js
Outdated
Show resolved
Hide resolved
San4es
reviewed
May 28, 2020
AntonSermyazhko
force-pushed
the
rrule_implementation_new
branch
from
1da74eb to
27f1ee9
Compare
AntonSermyazhko
force-pushed
the
rrule_implementation_new
branch
from
07eacf7 to
9e2499c
Compare
andrewmakarov
previously approved these changes
Jun 4, 2020
AryamnovEugeniy
previously approved these changes
Jun 4, 2020
js/ui/scheduler/utils.recurrence.js
Outdated
| wrongByMonthDay = true; | ||
| } | ||
| getRecurrenceString(object) { | ||
| if(!object || !object.freq) { |
There was a problem hiding this comment.
if(!object?.freq) {
There was a problem hiding this comment.
I don't like this approach.
@andrewmakarov what do you think?
There was a problem hiding this comment.
ie11 doesn't support optional chaining
There was a problem hiding this comment.
If I am not mistaken, we can use it since this PR. But, of course, I do not insist.
AntonSermyazhko
dismissed stale reviews from AryamnovEugeniy and andrewmakarov
via
c36eadb
San4es
suggested changes
Jun 4, 2020
AntonSermyazhko
force-pushed
the
rrule_implementation_new
branch
from
c36eadb to
91c889a
Compare
…urrenceProcessor()
andrewmakarov
approved these changes
Jun 5, 2020
AryamnovEugeniy
approved these changes
Jun 5, 2020
Yarovaya
approved these changes
Jun 5, 2020
San4es
approved these changes
Jun 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.